Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup-lisp doesn't notice various failures, and reports success without running proper tests. #13

Open
3b opened this issue Jan 8, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@3b
Copy link

3b commented Jan 8, 2024

With setup-lisp@v2, if the installation of a lisp fails (seems to fail on at least allegro,clisp,ecl on linux currently), it silently ignores it and runs tests on sbcl instead (or whatever lisp was installed in cached setup if it matches some other run), and the CI run passes.

With setup-lisp@v3, ecl,clisp still fails to install and runs tests on another lisp.
Allegro and ccl-bin/1.12.2 install but then 'passes' the tests with errors like

> Error: Invalid pathname component :HOME
> While executing: CCL::%PATH-STD-QUOTES, in process listener(1).

or

Warning: An error occurred
         (attempt to take the length of a non-sequence: :HOME) during
         the reading or evaluation of -e "(ros:run '((:eval\"(ros:asdf)\")(:eval\"(ros:quicklisp)\")(:load\"/home/runner/.roswell/init.lisp\")(:script \"/home/runner/work/_actions/40ants/run-tests/v2/run-tests.ros\"\"3b-bmfont\")(:quit ())))"
International Allegro CL Free Express Edition
10.1 [32-bit Linux (x86)] (Jan 23, 2023 8:47)
...
CL-USER(1): CL-USER(1): EOF
Really exit lisp [n]? 
; Initial Lisp Listener will be killing processes: 
;; processes killed
; Exiting
@3b
Copy link
Author

3b commented Jan 8, 2024

the :home errors are possibly contagious through caches or something, switched back to v2 and still got same thing on ccl until I deleted all the CI caches.

@svetlyak40wt svetlyak40wt added the bug Something isn't working label Jan 26, 2024
@svetlyak40wt
Copy link
Member

Oh, seems there are a few issues. I'm trying to resolve them now.

@svetlyak40wt
Copy link
Member

These issues are fixed in #14

I'll tag a new revision with v3 tag after a check on few my systems. For a while you can use v3.1.0 tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants