Add Sweet Scent method #163
Conversation
|
Changed how the rng files are named so that Sweet Scent isn't adding to the same file as static mons as they're not calculated the same. |
modules/menuing.py
Outdated
| @@ -299,7 +297,8 @@ def select_mon(self): | |||
| if self.game in ["POKEMON EMER", "POKEMON FIRE", "POKEMON LEAF"]: | |||
| while task_is_active("TASK_HANDLECHOOSEMONINPUT"): | |||
| context.emulator.press_button("A") | |||
| yield | |||
| # yield | |||
| context.emulator.run_single_frame() | |||
There was a problem hiding this comment.
Any reason you're running the frame instead of yielding?
There was a problem hiding this comment.
It randomly breaks when yielding. Works about 50% with yield, 100% with single frame
…fore attempting to navigate - restored `yield` in `select_mon` function - adjusted the sweet scent code to only try setting the sweet scent mon once
sweet scent bugfixes
|
Everything should be good on this now, all issues were worked out and confirmed for every game. |
|
Converting to draft for now, the other modes have been refactored quite heavily and this will need a bit of work to merge - will try to have a look at doing this if/when I get time. |
|
Closing this PR since it hasn't been worked on for a while. Also, the bot's code base has changed considerably since then which would unfortunately require this PR to be mostly if not completely rewritten. But still, good work nonetheless! 🙂 |
Adds a method for using Sweet Scent to hunt for shinies. Runs from battles in RSE and resets for FRLG.
Had to change a yield to a run_single_frame() to fix random behavior where a yield would cause you to enter manual mode. We're looking into fixing that.
The cursor options list in menu_parsers.py was also incorrect for FRLG. I copied the list and changed the number for Sweet Scent, but once I'm able to understand the numbers, they can be fixed.
Removed quest_log case I added for starters because I learned that the case was only true upon starting the quest_log, but not during the rest of it. Added a different way to properly check for it being finished.