Add basic success check to write_file() and use atomic file-replacing function
#161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng function This checks whether `write()` returns the correct number of characters written, and uses `os.replace()` to replace the file (which is supposed to be atomic) rather than deleting the old file and _then_ renaming the new one. This may or may not help with instances of file corruption what we have seen. Since it's difficult to reproduce the issue, it's hard to be sure about that. But at the very least it shouldn't make things worse.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checks whether
write()returns the correct number of characters written, and usesos.replace()to replace the file (which is supposed to be atomic) rather than deleting the old file and then renaming the new one.This may or may not help with instances of file corruption what we have seen. Since it's difficult to reproduce the issue, it's hard to be sure about that.
But at the very least it shouldn't make things worse.