Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dark mode #160

Merged
merged 27 commits into from
Jan 29, 2024
Merged

Add dark mode #160

merged 27 commits into from
Jan 29, 2024

Conversation

U2EZNeko
Copy link
Contributor

Combo box at bottom of "select profile" window.
Added various dark and black themes

@U2EZNeko
Added shitty dark-mode
d51dabf 
If someone wants to add a theme-switch button please go ahead. Right now it's hardcoded
@U2EZNeko
dark background for webUI
20082bb
@U2EZNeko
Merge branch '40Cakes:main' into main
c799190
@U2EZNeko
Merge branch 'main' of https://github.com/U2EZNeko/pokebot-gen3
512ea1a
@U2EZNeko
Added Themeing to example html
9a8a291 
Added multiple themes and a toggle button.

various dark and black themes.

Last selected theme will persist on reloads. (just device cache not serverside)
@U2EZNeko
Merge branch '40Cakes:main' into main
c61049f
@U2EZNeko
Merge branch '40Cakes:main' into main
337457b
@U2EZNeko
Merge branch 'main' of https://github.com/U2EZNeko/pokebot-gen3
1bf6fd0
@U2EZNeko
Added basic theming
05a438e 
Combo box at bottom of "select profile" window.
Added various dark and black themes
@U2EZNeko
Merge branch '40Cakes:main' into Nekos-theme-branch
b965d89
@U2EZNeko
removed old and now useless code
49f2c6b
@U2EZNeko
removed debug line
b3257c3
@U2EZNeko
Merge branch '40Cakes:main' into Nekos-theme-branch
0a6ca00
@U2EZNeko
Added 20 extra themes
24031a7
@U2EZNeko
Copy link
Contributor Author

Added like 20 more themes

@U2EZNeko
Copy link
Contributor Author

More themes for WebUI

@40Cakes
Copy link
Owner

40Cakes commented Dec 17, 2023

There is just FAR too many themes for the bot IMHO, would prefer if it was just a simple light/dark theme.
I don't think we really need a theme selector either, would probably just be easier to use Darkdetect and adjust accordingly to the user's OS preferences.

@40Cakes 40Cakes marked this pull request as draft January 24, 2024 03:04
@40Cakes
Copy link
Owner

40Cakes commented Jan 24, 2024

Converting to draft for the time being while I investigate and test darkdetect and ttkthemes.

@40Cakes
Copy link
Owner

40Cakes commented Jan 26, 2024

  • _set_button_colour() is not setting button colours at all with ttkthemes.
  • Load save state window crashes in dark mode if there are too many save states, with the following error:
X Error of failed request:  BadAlloc (insufficient resources for operation)
  Major opcode of failed request:  53 (X_CreatePixmap)
  Serial number of failed request:  297422
  Current serial number in output stream:  299385

image

image

@40Cakes 40Cakes changed the title Added themes to bot windows Add dark mode Jan 26, 2024
@40Cakes 40Cakes self-requested a review January 28, 2024 13:25
@40Cakes 40Cakes marked this pull request as ready for review January 28, 2024 13:26
@40Cakes 40Cakes merged commit 855fae3 into 40Cakes:main Jan 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@40Cakes 40Cakes Awaiting requested review from 40Cakes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@U2EZNeko @40Cakes