You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are several areas in the project that could benefit from enhancements in both the CMake setup and the code itself. Below are the suggested improvements:
CMake Improvements
Specify C++ version:
Explicitly set the C++ standard in your CMakeLists.txt file.
Modernize package finding:
Replace pkg_check_modules with find_package or use PkgConfig:: imported targets.
Thanks for opening this issue.
I applied the CMake Improvements on the project. Can you open a pull request and apply Code Improvements to the updated source code?
There are several areas in the project that could benefit from enhancements in both the CMake setup and the code itself. Below are the suggested improvements:
CMake Improvements
Specify C++ version:
Modernize package finding:
pkg_check_modules
withfind_package
or usePkgConfig::
imported targets.Explicit source file listing:
file(GLOB)
with explicit listing of source files to ensure CMake picks up new files correctly.Cross-platform support:
Proper c-ares integration:
FetchContent
to includec-ares
sincelibcurl
uses it whenENABLE_ARES
is set toON
.Code Improvements
Replace NULL with nullptr:
nullptr
instead ofNULL
throughout the codebase for improved type safety.RAII for CURL handle:
Use static_cast:
static_cast
for improved type safety.Utilize smart pointers:
The text was updated successfully, but these errors were encountered: