Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Feature to also Setup the corresponding IDP Group #152

Open
StevDa86 opened this issue Feb 15, 2023 · 3 comments
Open

Implement Feature to also Setup the corresponding IDP Group #152

StevDa86 opened this issue Feb 15, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request needs-more-info Not enough information to implement

Comments

@StevDa86
Copy link

It would be great if after creating the teams you could also store the appropriate IDP group in the team.
Here you could work e.g. with a regex or a filter

AD Group name: AAD-Test1-Dev-Admins
GH Teams Name: Test1-Dev-Admins
IDP group name: AAD-Test1-Dev-Admins

If an IDP group is set, no user object from the AD must be stored.

@primetheus primetheus self-assigned this Aug 17, 2023
@primetheus primetheus added the enhancement New feature or request label Aug 17, 2023
@primetheus
Copy link
Collaborator

@StevDa86 thanks for opening this up! I'm not entirely sure I understand the ask in this one... as I understand it, AD Group Name is the IdP Group Name. In your example, the GitHub team is missing the AAD, but the AD group contains it. In this case, what would be the desired behavior?

@primetheus primetheus added the needs-more-info Not enough information to implement label Aug 17, 2023
@StevDa86
Copy link
Author

i fixed this with an internal python script.
the idp groups are already filtered by the AAD integration (Enterprise App). i just check if ther is an IDP where no GitHub Team exists and then i create this team including mapping this team to the responding IDP group.

That was my intention for your app.

@primetheus
Copy link
Collaborator

ah, Ok! that makes sense. I think it still makes sense to do something like this in the app, so I'll pull this one into development.

sequenceDiagram
    autonumber
    participant GitHub
    participant team-sync
    participant IdP
    team-sync->>team-sync: process mapping
    team-sync->>GitHub: request team members
    team-sync->>IdP: request group members
    IdP->>team-sync: return group members
    team-sync->>team-sync: compare members
    team-sync-->>GitHub: create team if not exists
    team-sync->>GitHub: update team members
Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs-more-info Not enough information to implement
Projects
None yet
Development

No branches or pull requests

2 participants