Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AuthProviderFactory is out of date #4

Open
ghost opened this issue Nov 7, 2013 · 3 comments
Open

AuthProviderFactory is out of date #4

ghost opened this issue Nov 7, 2013 · 3 comments

Comments

@ghost
Copy link

ghost commented Nov 7, 2013

I've tried to use Google Plus provider on a CDI environment but it ends throwing the following exception

SocialAuthException: googleplus is not a provider or valid OpenId URL

Therefore, I've started debugging my app and socialauth implementations and I found out that AuthProviderFactory (org.brickred.socialauth) is out of date compared to SocialAuthConfig.

SocialAuthConfig has more providers than AuthProviderFactory (e.g googleplus)

Shortcut to compare both:
https://github.com/3pillarlabs/socialauth/blob/master/socialauth/src/main/java/org/brickred/socialauth/SocialAuthConfig.java

https://github.com/3pillarlabs/socialauth/blob/master/socialauth/src/main/java/org/brickred/socialauth/AuthProviderFactory.java

Thanks!

@tarun-nagpal
Copy link
Contributor

AuthProviderFactory is only for supporting initial version. It is deprecated now.
Use SocialAuthManager to use this API.

Please go through the following link to know it use:-

https://github.com/3pillarlabs/socialauth/wiki/Getting-Started-with-implementing-SocialAuth

@ghost
Copy link
Author

ghost commented Nov 12, 2013

I see, thanks for the answer. But AuthProviderFactory is being used on socialauth-cdi module:

https://github.com/3pillarlabs/socialauth/blob/master/socialauth-cdi/src/main/java/org/brickred/socialauth/cdi/SocialAuth.java

Line 164, login method. Using it with Google Plus leads to the SocialAuthException that I've mentioned...

@tarun-nagpal
Copy link
Contributor

Ok, thanks for letting us know. We will try to change it in next release.

flozano referenced this issue in flozano/socialauth May 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant