Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST]: Add modifier to popup of DisplayResult #7

Open
wcroteau opened this issue Nov 10, 2022 · 1 comment · May be fixed by #8
Open

[FEATURE REQUEST]: Add modifier to popup of DisplayResult #7

wcroteau opened this issue Nov 10, 2022 · 1 comment · May be fixed by #8

Comments

@wcroteau
Copy link

At the moment when your roll includes a modifier the DisplayResult component properly displays the modified total however there's no indication in the calculation that there was a modifier at play, it simply shows the dice rolled = total.

This is particularly noticeable when you roll a single die with modifier. For example Roll('1d20', { modifier: 3 } results in "16 = 19" (when the die roll is 16 which is mathematically nonsense at best and also confusing.

It would be preferable to display some notion of the modifier eg "16 +3 = 19"

@wcroteau wcroteau linked a pull request Nov 10, 2022 that will close this issue
@frankieali
Copy link
Contributor

Agreed. I'll test out that PR as soon as I'm able. It looks good at a glance. I'd like to see what happens when there are multiple modifiers or if the advanced roller is in play. E.g.: 3d6 + 4 + 4 or 3d6 + 2 + 1d8 + 4. I don't recall if the advanced rollers grouping method works. I think anything related to the advanced roller should probably go into a separate issue though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants