Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST]: Custom formatting of Box Controls #4

Open
wcroteau opened this issue Nov 3, 2022 · 2 comments · May be fixed by #9
Open

[FEATURE REQUEST]: Custom formatting of Box Controls #4

wcroteau opened this issue Nov 3, 2022 · 2 comments · May be fixed by #9

Comments

@wcroteau
Copy link

wcroteau commented Nov 3, 2022

It would be extremely nice if there was some way to modify (even just a little) of the UI for the Box Controls.

As a starter (and my biggest issue at the moment) is simply a way to override the labels for "Open Controls" and "Close Controls".

While these may well be appropriate for a very narrow scenario, when integrating this into my own project it raises the question "Controls for WHAT exactly"? Dice is only one aspect of my use-case. If I could somehow change this in say the config options I could instead have the labels "Open Dice Config" and "Close Dice Config" or similar.

@wcroteau wcroteau linked a pull request Nov 10, 2022 that will close this issue
@frankieali
Copy link
Contributor

Hi @wcroteau So, most of the UI controls I offer at the moment are mostly for demo purposes. It was to show how one could hook in a UI system to the @3d-dice/dice-box. Most other dice rollers I've encountered have baked the UI elements into the project. My goal was to keep these layers decoupled so developers could author their own UIs.
I'll look at your requests closer and see if I can make something that has more config options and could be useful in a project. I should probably make notes on the components as well which ones are mostly for demo purposes.

@wcroteau
Copy link
Author

Yeah, I more-or-less figured as much... I have however created a pull request which has this one small feature implemented if you're at all interested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants