Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DiceRollResult is typed incorrectly #4

Open
clevett opened this issue Sep 28, 2022 · 0 comments
Open

DiceRollResult is typed incorrectly #4

clevett opened this issue Sep 28, 2022 · 0 comments

Comments

@clevett
Copy link

clevett commented Sep 28, 2022

DiceRollResult in roll-types should be rolls: (DieRollBase | DieRoll)[];

A roll of 2d8 will return DieRoll but a roll of 1d20+1d6 will return DieRollBase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant