Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parseFinalResults doesn't add all dice results - only the most recent #8

Open
RobertTate opened this issue Jun 19, 2024 · 0 comments
Open

Comments

@RobertTate
Copy link

Just curious if this could be considered a possible future feature / improvement:

When I put the raw results value from onRollComplete into DiceResults.showResults, I can include logic that would let me add additional die to the roll using .add, and the DiceResults display would update the math and append the additional die into the calculation display.

However, the raw results value isn't calculating things like + or - modifiers into the display result. parseFinalResults fixes this, showing the correct final value. The only downside though is that it doesn't allow for the same type of appending functionality if you're .adding dice to the roll. Instead, it overwrites the previous value.

Could there be a way to adjust/extend parseFinalResults, so that it could allow for a continuous display of all rolls being made?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant