Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a <roll-dice> Web Component #78

Open
Danny-Engelman opened this issue May 15, 2023 · 2 comments
Open

Create a <roll-dice> Web Component #78

Danny-Engelman opened this issue May 15, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@Danny-Engelman
Copy link

Danny-Engelman commented May 15, 2023

I created an experimental <roll-dice> Web Component: https://jsfiddle.net/WebComponents/cmbvswq1/

It works; could be enhanced

  • I can't set display:inline-block (see code)
  • for the Web Component to load its dependencies, I need to jump thru some hoops to get that exported class (see code)
  • The DiceBox constructor requires a string to reference a DIV, would be nice if it accepted the DIV Node reference itself
@frankieali
Copy link
Contributor

This looks great. I'll see what I can adjust to support your web component.

@frankieali frankieali self-assigned this Jul 3, 2023
@frankieali frankieali added the enhancement New feature or request label Jul 3, 2023
@Danny-Engelman
Copy link
Author

Danny-Engelman commented Jul 3, 2023

No hurry for me. I now use: https://tympanus.net/codrops/2023/01/25/crafting-a-dice-roller-with-three-js-and-cannon-es/ because it creates true 1-6 dice faces

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants