Skip to content

Commit

Permalink
Fix some mistakes in integration tests
Browse files Browse the repository at this point in the history
  • Loading branch information
vijaiaeroastro committed Jul 1, 2024
1 parent 2465c1a commit 91d17fe
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 9 deletions.
13 changes: 5 additions & 8 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -604,6 +604,11 @@ jobs:
LATEST_TOTAL_SECONDS=$(echo $LATEST_TIME | awk -F: '{ print ($1 * 60) + $2 }')
echo "Latest SDK execution time in seconds: ${LATEST_TOTAL_SECONDS}"
LATEST_MUSTPASS=$(grep "MUSTPASS files passed" test_suites/latest_sdk_test.log | awk '{print $1}')
LATEST_MUSTFAIL=$(grep "MUSTFAIL files failed" test_suites/latest_sdk_test.log | awk '{print $1}')
echo "MUSTPASS: ${LATEST_MUSTPASS}"
echo "MUSTFAIL: ${LATEST_MUSTFAIL}"
integration-tests-last-two-releases:
runs-on: ubuntu-20.04
Expand Down Expand Up @@ -790,14 +795,6 @@ jobs:
echo "LATEST_MUSTPASS=${LATEST_MUSTPASS}" >> $GITHUB_ENV
echo "LATEST_MUSTFAIL=${LATEST_MUSTFAIL}" >> $GITHUB_ENV
# Fail the job if counts are inconsistent

This comment has been minimized.

Copy link
@gangatp

gangatp Jul 3, 2024

Collaborator

why is this removed?

This comment has been minimized.

Copy link
@vijaiaeroastro

vijaiaeroastro Jul 3, 2024

Author Collaborator

Only the following have two results to compare:

  • integration-tests-last-two-releases
    
  • integration-test-last-commit-and-last-release
    

For these two, there is nothing to compare against:

  • integration-tests-latest-release
    
  • integration-tests-latest-commit
    

The last release one just runs on the last release, and the latest commit one simply runs on the latest commit. What would we compare them against?

This comment has been minimized.

Copy link
@gangatp

gangatp Jul 3, 2024

Collaborator

can we compare this case integration-test-last-commit-and-last-release. are we comparing that already

This comment has been minimized.

Copy link
@vijaiaeroastro

vijaiaeroastro Jul 3, 2024

Author Collaborator

Yes, in the last-commit-and-last-release workflow, we have the check and the action will fail if the count is not equal

if [ "$LATEST_MUSTPASS" != "$LATEST_MUSTFAIL" ]; then
echo "MUSTPASS or MUSTFAIL counts are inconsistent"
exit 1
else
echo "MUSTPASS and MUSTFAIL counts are consistent"
fi
integration-test-last-commit-and-last-release:
runs-on: ubuntu-20.04
needs: [set-integration-tests-status]
Expand Down
2 changes: 1 addition & 1 deletion submodules/zlib
Submodule zlib updated 73 files
+1 −11 .gitignore
+19 −24 CMakeLists.txt
+0 −10 ChangeLog
+2 −1 FAQ
+8 −8 Makefile.in
+3 −3 README
+4 −5 configure
+1 −1 contrib/delphi/ZLib.pas
+1 −1 contrib/dotzlib/DotZLib/ChecksumImpl.cs
+1 −1 contrib/dotzlib/DotZLib/UnitTests.cs
+3 −3 contrib/infback9/inftree9.c
+2 −2 contrib/infback9/inftree9.h
+2 −2 contrib/iostream3/zfstream.h
+1 −1 contrib/minizip/Makefile
+1 −1 contrib/minizip/configure.ac
+1 −1 contrib/minizip/ioapi.h
+2 −16 contrib/minizip/miniunz.c
+4 −4 contrib/minizip/unzip.c
+1 −1 contrib/minizip/unzip.h
+5 −16 contrib/minizip/zip.c
+2 −2 contrib/minizip/zip.h
+0 −43 contrib/nuget/nuget.csproj
+0 −22 contrib/nuget/nuget.sln
+1 −1 contrib/pascal/zlibpas.pas
+4 −4 contrib/puff/puff.c
+75 −81 contrib/vstudio/readme.txt
+4 −4 contrib/vstudio/vc10/zlib.rc
+1 −1 contrib/vstudio/vc10/zlibvc.def
+4 −4 contrib/vstudio/vc11/zlib.rc
+1 −1 contrib/vstudio/vc11/zlibvc.def
+4 −4 contrib/vstudio/vc12/zlib.rc
+1 −1 contrib/vstudio/vc12/zlibvc.def
+4 −4 contrib/vstudio/vc14/zlib.rc
+1 −1 contrib/vstudio/vc14/zlibvc.def
+0 −409 contrib/vstudio/vc17/miniunz.vcxproj
+0 −405 contrib/vstudio/vc17/minizip.vcxproj
+0 −473 contrib/vstudio/vc17/testzlib.vcxproj
+0 −409 contrib/vstudio/vc17/testzlibdll.vcxproj
+0 −32 contrib/vstudio/vc17/zlib.rc
+0 −602 contrib/vstudio/vc17/zlibstat.vcxproj
+0 −158 contrib/vstudio/vc17/zlibvc.def
+0 −179 contrib/vstudio/vc17/zlibvc.sln
+0 −875 contrib/vstudio/vc17/zlibvc.vcxproj
+4 −4 contrib/vstudio/vc9/zlib.rc
+1 −1 contrib/vstudio/vc9/zlibvc.def
+11 −36 deflate.c
+2 −33 deflate.h
+1 −1 doc/algorithm.txt
+2 −2 examples/gzlog.c
+1 −1 examples/zran.c
+6 −2 gzguts.h
+6 −6 gzlib.c
+1 −1 inflate.c
+3 −3 inftrees.c
+2 −2 inftrees.h
+1 −1 old/visual-basic.txt
+1 −1 os400/README400
+3 −3 os400/zlib.inc
+5 −5 qnx/package.qpg
+12 −13 test/example.c
+16 −16 test/minigzip.c
+2 −2 treebuild.xml
+3 −17 trees.c
+18 −2 win32/DLL_FAQ.txt
+4 −4 win32/README-WIN32.txt
+9 −1 zconf.h
+9 −1 zconf.h.cmakein
+9 −1 zconf.h.in
+3 −3 zlib.3
+ zlib.3.pdf
+11 −11 zlib.h
+100 −100 zlib.map
+24 −3 zutil.h

0 comments on commit 91d17fe

Please sign in to comment.