Skip to content
This repository has been archived by the owner on Aug 24, 2021. It is now read-only.

Build artifacts with docker #49

Open
tebeka opened this issue Dec 30, 2019 · 2 comments
Open

Build artifacts with docker #49

tebeka opened this issue Dec 30, 2019 · 2 comments

Comments

@tebeka
Copy link
Member

tebeka commented Dec 30, 2019

Currently make artifact-linux-x86_64 will build the atrifact on the host machine. IMO we should build it via docker container (can do with a shared volume or copy from the build container).

@yonidavidson WDYT?

@yonidavidson
Copy link
Collaborator

Pros - good idea - I actually used both techniques.
shared volume is easier (but you still have a host), copy from container is cleaner but you need to save the container id (you get it from the run command), can be annoying to write it when you develop in Java since build is long but in Go is the prefered way IMO.
Cons - lets say we move our project to github actions for example so we can build in mac and windows, if we build in docker we won't be able to leverage the platforms for the different builds

@tebeka
Copy link
Member Author

tebeka commented Jan 1, 2020

Cons - lets say we move our project to github actions for example so we can build in mac and windows, if we build in docker we won't be able to leverage the platforms for the different builds

Agree. However the compatibility problem is very linux specific

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants