Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink how we're storing the routing configuration #30

Closed
whitlockjc opened this issue Jun 10, 2016 · 3 comments
Closed

Rethink how we're storing the routing configuration #30

whitlockjc opened this issue Jun 10, 2016 · 3 comments

Comments

@whitlockjc
Copy link
Contributor

Right now, we're using a mix annotations to perform the wiring of the router. This is working fine but with #18 and #29, we're quickly getting to the point where we're adding more and more things. Maybe it's time we look into storing JSON in a single annotation?

@mpnally
Copy link

mpnally commented Jun 13, 2016

What would be the advantage?

@whitlockjc
Copy link
Contributor Author

I created this when I thought we were going to add yet another configuration annotation for #29. We ended up not doing that so we can keep this in the backlog for now. But to answer your question, Kubernetes stuff structured data (JSON) into annotations when it makes sense and I think when our routing rules become more complex and/or repetitive, we might want to at least revisit this. But nothing is changing right now because it's not necessary now that #29 is done without a new annotation.

@whitlockjc
Copy link
Contributor Author

This is not important right now and can be re-opened if/when it ever is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants