You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 24, 2021. It is now read-only.
We have a scenario in auth where it uses two hooks, the first, it cares about what implementing modules to with the data, i.e. the modules return a value that influences outcomes. The second hook, auth doesn't care what the implementing modules to with the data, it is merely a notification.
Things brings in some confusing aspects as to if a hook will return data or not.
We can clear this up by introducing an overlapping function in Web called notify which calls Web::callHooks but does nothing with the returning data. With notify, we could also rewrite errors to logs but surround with try/catch to try and avoid halts in execution... what to you think @careck?
The text was updated successfully, but these errors were encountered:
We have a scenario in auth where it uses two hooks, the first, it cares about what implementing modules to with the data, i.e. the modules return a value that influences outcomes. The second hook, auth doesn't care what the implementing modules to with the data, it is merely a notification.
Things brings in some confusing aspects as to if a hook will return data or not.
We can clear this up by introducing an overlapping function in Web called notify which calls Web::callHooks but does nothing with the returning data. With notify, we could also rewrite errors to logs but surround with try/catch to try and avoid halts in execution... what to you think @careck?
The text was updated successfully, but these errors were encountered: