From 7e63bbff02882bf2b593d3bb0c5a9a89302f15e7 Mon Sep 17 00:00:00 2001
From: Preeti Bansal <146315451+preetibansalui@users.noreply.github.com>
Date: Tue, 3 Dec 2024 02:15:14 +0530
Subject: [PATCH] fix: changed pagination label for select (#18166)

* fix: changed pagination label for select

* fix: avt test cases

---------

Co-authored-by: Gururaj J <89023023+Gururajj77@users.noreply.github.com>
---
 e2e/components/Pagination/Pagination-test.avt.e2e.js          | 4 ++--
 packages/react/src/components/Pagination/Pagination.tsx       | 2 +-
 .../src/components/Pagination/__tests__/Pagination-test.js    | 4 ++--
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/e2e/components/Pagination/Pagination-test.avt.e2e.js b/e2e/components/Pagination/Pagination-test.avt.e2e.js
index c52ff4854589..94887f2bdefa 100644
--- a/e2e/components/Pagination/Pagination-test.avt.e2e.js
+++ b/e2e/components/Pagination/Pagination-test.avt.e2e.js
@@ -50,10 +50,10 @@ test.describe('@avt Pagination', () => {
       name: 'Items per page:',
     });
     const pageSelector = page.getByRole('combobox', {
-      name: 'Page number, of 11 pages',
+      name: 'Page of 11 pages',
     });
     const updatedPageSelector = page.getByRole('combobox', {
-      name: 'Page number, of 3 pages',
+      name: 'Page of 3 pages',
     });
     const nextPageButton = page.getByRole('button', { name: 'Next page' });
     const prevPageButton = page.getByRole('button').first();
diff --git a/packages/react/src/components/Pagination/Pagination.tsx b/packages/react/src/components/Pagination/Pagination.tsx
index 4ba2f2a73d43..306a73243ca3 100644
--- a/packages/react/src/components/Pagination/Pagination.tsx
+++ b/packages/react/src/components/Pagination/Pagination.tsx
@@ -388,7 +388,7 @@ const Pagination = React.forwardRef(function Pagination(
             <Select
               id={`${prefix}-pagination-select-${inputId}-right`}
               className={`${prefix}--select__page-number`}
-              labelText={`Page number, of ${totalPages} pages`}
+              labelText={`Page of ${totalPages} pages`}
               inline
               hideLabel
               onChange={handlePageInputChange}
diff --git a/packages/react/src/components/Pagination/__tests__/Pagination-test.js b/packages/react/src/components/Pagination/__tests__/Pagination-test.js
index 68c7a4ef4469..3a5d5ef6d8c5 100644
--- a/packages/react/src/components/Pagination/__tests__/Pagination-test.js
+++ b/packages/react/src/components/Pagination/__tests__/Pagination-test.js
@@ -118,7 +118,7 @@ describe('Pagination', () => {
           onChange={onChange}
         />
       );
-      await userEvent.selectOptions(screen.getByLabelText(/Page number/), '2');
+      await userEvent.selectOptions(screen.getByLabelText(/Page/), '2');
       expect(onChange).toHaveBeenCalledTimes(1);
       expect(onChange).toHaveBeenCalledWith(
         expect.objectContaining({ page: 2 })
@@ -237,7 +237,7 @@ describe('Pagination', () => {
       );
       expect(screen.getByText('1–1 of 2 items')).toBeInTheDocument();
 
-      await userEvent.selectOptions(screen.getByLabelText(/Page number/), '2');
+      await userEvent.selectOptions(screen.getByLabelText(/Page/), '2');
       expect(screen.getByText('2–2 of 2 items')).toBeInTheDocument();
     });