Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change extensions layout #32

Open
klando opened this issue Aug 13, 2013 · 5 comments
Open

Change extensions layout #32

klando opened this issue Aug 13, 2013 · 5 comments

Comments

@klando
Copy link

klando commented Aug 13, 2013

the current inclusion of pg_find_plans into pg_stat_plans is not helpful for packaging.

What about the following layout ?
├── debian
├── Makefile
├── pg_find_plans
│   └── Makefile
└── pg_stat_plans
└── Makefile

The top Makefile allows to builld with options like that :
make PG_STAT_PLANS=1 PG_FIND_PLANS=1 # (the default)
and each sub-Makefile works as usual.

Even if we don't want to keep the debian/ (and a rpm/ ?) I do prefer this layout.

OK ?

@petergeoghegan
Copy link
Contributor

@klando Makes sense to me - it would be nice to build/install everything in one go. I think, just for the record, that it was the correct decision to make pg_find_plans a separate module that resides in the same source control repository.

The convention I favour for pg_find_plans is that its version and dependency on pg_stat_plans should match pg_stat_plans (So right now they're all 1.0, which is good). We should stick to this.

There is only going to be an rpm/ if someone steps forward and makes the effort to work on that. It's unlikely to be me.

@terrorobe
Copy link
Contributor

I'll probably have a look at rpm packaging in the near future

@Hubbitus
Copy link

Hubbitus commented Aug 4, 2015

@terrorobe, do you packaging it into rpm already?

@lfittl
Copy link

lfittl commented Aug 4, 2015

@Hubbitus We ended up not using pg_stat_plans due to #39

@Hubbitus
Copy link

Hubbitus commented Aug 4, 2015

@terrorobe thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants