Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move HaloBox Fixed integrals to Lagrangian space #428

Open
daviesje opened this issue Sep 16, 2024 · 1 comment
Open

Move HaloBox Fixed integrals to Lagrangian space #428

daviesje opened this issue Sep 16, 2024 · 1 comment
Labels
context: C backend Changes occur predominantly in the C code context: v4-prep This issue regards changes to the v4-prep branch type: feature: accuracy New code that improves overall accuracy/concistency

Comments

@daviesje
Copy link
Contributor

The CMF integrals which occur between the minimum sampled halo mass and the minimum source mass currently are performed on PerturbedField.density, similar to the default ionisation model. They should be calculated on the evolved initial conditions InitialConditions.lowres_density instead (see Trac+22 https://arxiv.org/pdf/2109.10375).

At first we can assume that these small sources don't move from the ICs, but if we want to implement them for the larger halos we should perturb their positions using the 2LPT functions.

The change itself will be easy to make, but we will need to test how it effects these small sources, and if we set FIXED_HALO_GRIDS, the fixed source boxes.

@daviesje daviesje added context: C backend Changes occur predominantly in the C code context: v4-prep This issue regards changes to the v4-prep branch type: feature: accuracy New code that improves overall accuracy/concistency labels Sep 16, 2024
@daviesje
Copy link
Contributor Author

daviesje commented Oct 7, 2024

A stopgap for this has been implemented in #433. Where only the sources below the sampler are treated as non-moving and calculated from the evolved IC density, and FIXED_HALO_GRID uses the Eulerian density.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
context: C backend Changes occur predominantly in the C code context: v4-prep This issue regards changes to the v4-prep branch type: feature: accuracy New code that improves overall accuracy/concistency
Projects
Status: Ready
Development

No branches or pull requests

1 participant