Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a wrapper-level function to convert RNG to halo properties #375

Open
daviesje opened this issue Apr 3, 2024 · 0 comments
Open

Create a wrapper-level function to convert RNG to halo properties #375

daviesje opened this issue Apr 3, 2024 · 0 comments
Assignees
Labels
context: v4-prep This issue regards changes to the v4-prep branch type: feature: code New ability in the code (user-side)

Comments

@daviesje
Copy link
Contributor

daviesje commented Apr 3, 2024

The halo sampler correlates the halo properties (stellar mass and SFR) based on the sampling of its descendant, which is calculated backwards in time. Due to the presence of feedback, we cannot finalise the halo properties until we have the previous snapshot's (higher z) Lyman Werner and Ionising background.

As such, the current behaviour passes the correlated gaussian variables (which become the lognormal scatter in each property) backward in time, and then scales them to the mean (which includes the feedback) in the forward time-loop. This is efficient when running the lightcone, however it means that getting the star-formation rate or stellar mass in the halo catalogues is tedious.

To help with analysis, there should be an exposed function which loops through a catalogue and applies set_halo_properties() from HaloBox.c to a halo catalogue, given radiative backgrounds if required.

@daviesje daviesje added context: v4-prep This issue regards changes to the v4-prep branch type: feature: code New ability in the code (user-side) labels Apr 3, 2024
@daviesje daviesje self-assigned this Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
context: v4-prep This issue regards changes to the v4-prep branch type: feature: code New ability in the code (user-side)
Projects
Status: In progress
Development

No branches or pull requests

1 participant