Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete the XraySourceBox output #366

Open
daviesje opened this issue Mar 28, 2024 · 0 comments
Open

Complete the XraySourceBox output #366

daviesje opened this issue Mar 28, 2024 · 0 comments
Assignees
Labels
context: C backend Changes occur predominantly in the C code context: python wrapper Predominantly affecting the Python wrapper context: v4-prep This issue regards changes to the v4-prep branch priority: high type: refactor Code refactoring / restyling for internal benefit

Comments

@daviesje
Copy link
Contributor

daviesje commented Mar 28, 2024

The new halo model introduced a new output structure XraySourceBox, which contains the filtered star formation rate densities required to calculate the xray and lyman alpha heating fields in spin_temperature. This was separated from the main spin temperature code in order to support the use of source fields directly from each required redshift, rather than relying on linear growth which was impossible for the halos.

I would like to extend this functionality to the non-halo model, using the PerturbedField at the actual source redshift, and also supporting the new spherical shell filter, which directly ties the radiation received by a cell to the distance and redshift of the sources. This would also allow us to further clean up the ComputeTs function by combining the generation of the filtered SFR grids in the halo-based and density grid-based calculations.

The implementation of the boxes themselves also needs to be cleaned up a little, since it requires messing with some of the private attributes in order to allow multiple computations at different redshifts.

@daviesje daviesje added the context: v4-prep This issue regards changes to the v4-prep branch label Mar 28, 2024
@daviesje daviesje self-assigned this Mar 28, 2024
@steven-murray steven-murray added context: python wrapper Predominantly affecting the Python wrapper context: C backend Changes occur predominantly in the C code type: refactor Code refactoring / restyling for internal benefit priority: high labels Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
context: C backend Changes occur predominantly in the C code context: python wrapper Predominantly affecting the Python wrapper context: v4-prep This issue regards changes to the v4-prep branch priority: high type: refactor Code refactoring / restyling for internal benefit
Projects
Status: Ready
Development

No branches or pull requests

2 participants