Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Photon Conservation Model to Python #364

Open
daviesje opened this issue Mar 28, 2024 · 0 comments
Open

Move Photon Conservation Model to Python #364

daviesje opened this issue Mar 28, 2024 · 0 comments
Labels
context: v4-prep This issue regards changes to the v4-prep branch type: refactor Code refactoring / restyling for internal benefit

Comments

@daviesje
Copy link
Contributor

The current implementation of the redshift-dependent photon conservation approximation spans the Python Wrapper and C backend in a very awkward way, relying on many globally defined arrays which have to be passed back and forth. This makes changes to the model very difficult.

Since the model has to run a calibration simulation from the wrapper, and otherwise consists of relatively light array operations, I see no reason not to migrate the entire model to the wrapper. In this way we can simply pass a structure containing all the photon conservation info into ionize_box.

@daviesje daviesje added context: v4-prep This issue regards changes to the v4-prep branch type: refactor Code refactoring / restyling for internal benefit labels Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
context: v4-prep This issue regards changes to the v4-prep branch type: refactor Code refactoring / restyling for internal benefit
Projects
Status: Ready
Development

No branches or pull requests

1 participant