C restructure #417
Merged
C restructure #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Aug 8, 2024
| lib.Broadcast_struct_global_PS(up(), cp()) | ||
| lib.Broadcast_struct_global_UF(up(), cp()) | ||
| lib.Broadcast_struct_global_IT(up(), cp(), ap(), fo()) | ||
| lib.Broadcast_struct_global_all(up(), cp(), ap(), fo()) |
There was a problem hiding this comment.
This is not your task necessarily (certainly not in this PR) but I'd love to have a nicer lower level wrapper that just exposes these functions directly in Python style, so you could call like
broadcast_structs(up, cp, ap, fo)
```There was a problem hiding this comment.
do you mean just adding something like the following to the wrapper? these functions are already exposed
def broadcast_inputstructs(up,cp,ap=None,fo=None):
if not isinstance(up,UserParams) or not isinstance(cp,CosmoParams):
raise ValueError
if isinstance(ap,AstroParams) and isinstance(fo,FlagOptions):
lib.Broadcast_struct_global_all(up(), cp(), ap(), fo())
lib.Broadcast_struct_global_noastro(up(), cp())
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A draft pull request for a restructure of the C backend. #359
Changes:
GenerateICs.c#include "X.c"have been removedbuild.cffihas been changed to make it clear which functions and definitions are available to the python wrapper.cdef()calls as well as in theset_source()header files.cdef()code cannot contain compiler directives, as a result new header files were created labelled_something_wrapper.hto contain exposed definitions. these are also included in the relevant header files for the backend so we only have to edit one file to expose a function properly.UsefulFunctions.candps.chave been split up into functions grouped together by their themes e.gcosmology.cthermochem.chmf.cetc...Todos:
unsigned long long, but single axis indices are sometimesintorunsigned long long.float, most of these should bedoubleunless they are a grid which takes up significant memory/disk space Migration toward double precision floating point numbers #361heating_helper_progs.cas well