Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Req.] Composable data reader #30

Open
steven-murray opened this issue Jan 14, 2020 · 0 comments
Open

[Feature Req.] Composable data reader #30

steven-murray opened this issue Jan 14, 2020 · 0 comments
Assignees
Labels
API Breaking A change that breaks backwards compatibility context: framework type: feature: code New ability in the code (user-side)
Milestone

Comments

@steven-murray
Copy link
Member

Is your feature request related to a problem? Please describe.

Currently, if any data is required for a given likelihood from a file, the LikelihoodBaseFile class is used, but then the user has to sub-class this class to implement their own method for actually reading the data. This causes a problem, not only because that's annoying to do, but because we can't provide any more than one default reader without causing combinatorial explosion of subclasses.

Describe the solution you'd like

It would be much more desirable to let the user pass in a reader of their own -- a callable that takes a single argument datafile (which could be a list of files), and returns an object that must match whatever checks the particular likelihood describes.

Describe alternatives you've considered

The data reader could also be a class, but it's probably much simpler just to receive any callable with the correct signature.

This will break the API. Therefore we should decide before v1.0.0

@steven-murray steven-murray added API Breaking A change that breaks backwards compatibility type: feature: code New ability in the code (user-side) context: framework and removed enhancement labels Sep 30, 2020
@steven-murray steven-murray self-assigned this Jan 28, 2021
@steven-murray steven-murray added this to the v1 milestone Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Breaking A change that breaks backwards compatibility context: framework type: feature: code New ability in the code (user-side)
Projects
None yet
Development

No branches or pull requests

1 participant