Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What to do with non-functional pages #248

Open
PureTryOut opened this issue Jan 5, 2024 · 5 comments
Open

What to do with non-functional pages #248

PureTryOut opened this issue Jan 5, 2024 · 5 comments

Comments

@PureTryOut
Copy link
Contributor

Due to the website currently being a static dump of the old interactive website a lot of things currently don't really work. Examples:

  • /services/m=bugtracker_v4/index-2.html. A page to report bugs, but those are supposed to be posted on GitLab instead and doesn't actually work
  • /services/m=advert. None of the pages there actually work, they're all blank.
  • /services/m=adventurers-log. I was actually excited when I saw this as I used to love the adventurer log, but sadly it doesn't work and there doesn't currently seem to be a way to retrieve the required info for such functionality at all.
  • /services/m=forum. Seems to be a dump of the old forum at the time. Quite a lot of pages are in there but no links actually work. I also wonder what the use is of keeping this around.
  • /services/m=itemdb_rs. The pages display, but the prices shown are completely outdated and wrong. I don't see use in keeping it around if it's not going to show updated info.
  • /services/m=poll. Well the pages work, but those are polls from 2009 and before. They're not linked anywhere either and the navigation bar on those pages link to non-existing pages.

There is probably more. If the goal is archival than I would rather let that be done by the Wayback machine (for example https://web.archive.org/web/20091208041147if_/http://www.runescape.com/title.ws) or keep that in a separate repo. Currently this repository is quite big to clone because of a lot of this stuff and it doesn't even represent the current state of 2009scape.

What are your thoughts?

@Ceikry
Copy link
Member

Ceikry commented Jan 5, 2024

bug report page should be removed, we already have the forums and gitlab itself.

Adventurer's log might see an implementation one day when we have a better API.

The old forum is there for archival purposes, and could theoretically just be scrapped.

itemdb_rs showing """outdated""" prices is completely and entirely the most useful thing on the website. Knowing the prices of things as they were authentically in 2009 is a good guidance/reference point for how the economy of 2009scape itself should work.

The old polls are also kinda useful, but could be axed too. Not particularly necessary.

@PureTryOut
Copy link
Contributor Author

Knowing the prices of things as they were authentically in 2009 is a good guidance/reference point for how the economy of 2009scape itself should work.

Fair. In that case however it would be nice to link to it from somewhere, but at those pages make clear that it's about old prices which do not reflect the current game.
I'll make a PR for it.

@ryannathans
Copy link
Collaborator

The adventurer's log could be implemented once I have fleshed out my API a bit more. If we could get some high level requirements I'll know what to flesh out

@dginovker
Copy link
Member

dginovker commented Jan 8, 2024

From https://runescape.fandom.com/wiki/Adventurer%27s_Log?oldid=2090380

* Quest complete: <quest>
* <n> Quest points obtained (every 10 quest points)
* Levelled up <skill> (whenever a skill is levelled)
* <n> total levels gained (every 100 levels)
* Every 2,000,000 experience trained after 99
* Levelled all skills over <n> (based on the level of the lowest skill)
* I killed <player>
* I killed <monster>
* Item found: <item>
* Number songs unlocked (every 100 songs)
* Defeat a Champion in the [Champions' Challenge](https://runescape.fandom.com/wiki/Champions%27_Challenge)
* Completing a holiday event.

Maybe we could ask on the forums what people would like to see as well

@ryannathans
Copy link
Collaborator

Surely "I killed" and "item found" are for rares/bosses only?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants