Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working with Angular 4 #1

Open
jogelin opened this issue Feb 15, 2017 · 7 comments
Open

Not working with Angular 4 #1

jogelin opened this issue Feb 15, 2017 · 7 comments
Assignees
Labels

Comments

@jogelin
Copy link

jogelin commented Feb 15, 2017

Do you planify to support this library ?

@thekalinga
Copy link
Member

thekalinga commented Feb 15, 2017

Is there a specific reason you need dist folder to be present?

Instead it has lib directory, which is properly referenced in both index.d.ts & index.js

@jogelin
Copy link
Author

jogelin commented Feb 15, 2017

I don't need a dist folder...it's is referenced in the index.ts..

When I install your lib
npm install x-ng4-http-interceptor --save
I don't have lib folder

@thekalinga
Copy link
Member

thekalinga commented Feb 15, 2017

Do you planify to support this library ?

I am certain that I'll not have time to support the issues in the medium to long term. So, I submitted a pull request to angular2-interceptors, but he did not respond to my pull request :). I believe he too is busy.

So, I'm forced to publish my own version to support my product, which I kept it as low profile (the x- prefix) to give room to the actual ng2-http-interceptor

The code have decent amount of documentation & a demo that covers various ways in which the library can be used

I am using this library to support oauth2 flow which is quite complex & the library works reasonably well.

@thekalinga
Copy link
Member

thekalinga commented Feb 15, 2017

npm install x-ng4-http-interceptor --save

Sorry, v2 changes are not yet merged v4. v2 is reasonably tested & there is a demo that you can use to know how to deal with your own usecases.

If you need it for v4, I may need to create a new repo & publish a new npm artifact

@jogelin
Copy link
Author

jogelin commented Feb 15, 2017

Ok I understand. Thx for your time.

yes I was talking about the v4.

I close the issue.

@jogelin jogelin closed this as completed Feb 15, 2017
@thekalinga thekalinga changed the title No dist folder in the published npm package Angular 4 compatibility is not working Feb 15, 2017
@thekalinga
Copy link
Member

thekalinga commented Feb 15, 2017

I can publish a new version for v4 compatibility, if you are willing to test (most likely it should work as there are no major changes between v2 & v4 w.r.t http api)

@thekalinga
Copy link
Member

I'm keeping it open for now.

@thekalinga thekalinga reopened this Feb 15, 2017
@thekalinga thekalinga self-assigned this Feb 15, 2017
@thekalinga thekalinga added the bug label Feb 15, 2017
@thekalinga thekalinga changed the title Angular 4 compatibility is not working Not working with Angular 4 Feb 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants