Emit with multiple parameters

[david-sailplan]

The Client.emit and Client.emit_with_ack only seem to support a single data parameter

This causes issues for servers who are expecting multiple parameters for the data for these events

rust.rs

socket.emit_with_ack("foo", json!("{ack:true}", duration, callback) 

example_socketio_server.js

socket.on("foo", async (userId, body, callback)=>{})

no mater what is placed in data, it will place all data under the "userId" and no way to populate the body parameter.

Is there a workaround that could fix this?

[1c3t3a]

Do you use a special parser for this on the server side?

[david-sailplan]

No. We don't use any parser beyond the default behavior of the nodejs package server-side.

const io = socketio(server, { path: '/socket', transports: ['websocket'] })

As seen here the emit function takes an unbound number of arguments. This behavior is handled server side as per this example

[SSebo]

@david-sailplan

rust-socketio/socketio/src/socket.rs

Lines 105 to 109 in 4ac27c7

	let payload = if serde_json::from_str::<serde_json::Value>(&str_data).is_ok() {
	format!("[\"{}\",{}]", String::from(event), str_data)
	} else {
	format!("[\"{}\",\"{}\"]", String::from(event), str_data)
	};

currently is limit to only two params, L108 accept a string, so there is a tricky way socket .emit("foo", "bar1\",\"bar2\", \"bar3"), you can have a try.

[syshriki9]

@SSebo is there currently a better way to do this using "binary data/attachments"?

I know your todo list is probably long, but a proper interface for encoding multiple message parameters would be a great feature :)

[SSebo]

@SSebo is there currently a better way to do this using "binary data/attachments"?

I know your todo list is probably long, but a proper interface for encoding multiple message parameters would be a great feature :)

@1c3t3a @nshaaban-cPacket they are the owners of this repo, I forward your message to them :)

[SSebo]

#249 I made a PR @david-sailplan @syshriki9 You can have a try.

[syshriki9]

Wow that was fast!, Thanks @SSebo.

As David mentioned, it seems to work.

[syshriki9]

@SSebo @1c3t3a do you guys think this feature will make it into the master?

[shenjackyuanjie]

also. that……
hmmm
well, now the .on can not accept mult payload, so ……
anther old issue

[shenjackyuanjie]

This issue is mostly done, likely able to close