Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support for private keys #172

Open
brizzbuzz opened this issue Aug 21, 2023 · 2 comments
Open

Better support for private keys #172

brizzbuzz opened this issue Aug 21, 2023 · 2 comments

Comments

@brizzbuzz
Copy link

Summary

Hi, I've been really enjoying most of the UX around storing secrets in 1Password and having the connector inject them into K8. However, one area that feels like it could use some more love is the need for storing and accessing private keys. Recently, while setting up a GitHub App, I found that attempting to store the private key as a "password" field was messing up the formatting of the key, leading to an error. The only solution I have found is to store the private key as a "text" field.

It's not the end of the world, but it would be nice to either

  1. Have a dedicated "private key" type field
  2. Allow for files attached to a secret to be uploaded to the K8 secret

This way, users could store their keys in a way that makes more sense than plaintext inside 1Password.

Use cases

See above

Is there a workaround to accomplish this today?

See above

@rhaex
Copy link

rhaex commented Oct 12, 2023

I experienced the same issue, and I have solved it with option 2 as that is already possible.
Just add the private key as a file to the 1Password item, and it will end up in the k8s secret with the key as in 1Password and value the String contents of the file (without messing up the formatting).

This used to be in the documentation, but for some reason they removed almost all usable documentation starting in v1.7.1 and I have no idea where to find this now, but in the older docs you can see that files are supported https://github.com/1Password/onepassword-operator/tree/v1.7.0#usage

@mrclrchtr
Copy link

I started to use https://external-secrets.io/ in combination with op-connect. This is much more configurable and easy to use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants