Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow auto restarting of all types of workloads #158

Open
otherguy opened this issue May 24, 2023 · 5 comments
Open

Allow auto restarting of all types of workloads #158

otherguy opened this issue May 24, 2023 · 5 comments

Comments

@otherguy
Copy link

Currently, the operator only restarts Deployments but no other type of workload. For example DaemonSets cannot be restarted even though their restart mechanism is the same.

We're using Rollouts from Argo Rollouts which are a drop-in replacement for Deployment objects. Their restart mechanism is identical, yet the operator only looks for Deployments.

Please support restarting all types of workloads, or at least let us add an annotation to workloads to let the operator attempt to restart them, even though it doesn't know about the workloads specific features.

This is tangentially related to #18.

@mabrikan
Copy link

mabrikan commented Oct 5, 2023

I agree. We are having the same issue. We are using Argo Rollouts.

@edif2008
Copy link
Member

Hey folks! 👋

Thank you for raising this.
We do see the value of supporting auto-restarting for multiple types of workloads, so it's working looking deeper into this.

I will let you know when the team picks this up and there's any progress on this. Thank you for your patience. 😊

@otherguy
Copy link
Author

@edif2008 thanks! We're using more and more Rollouts, so this would be crucial!

@jillianwilson jillianwilson self-assigned this Jan 26, 2024
@jillianwilson jillianwilson removed their assignment Feb 9, 2024
@otherguy
Copy link
Author

otherguy commented Mar 7, 2024

Hey @edif2008 :) Just wanted to ask if there has been any progress on this?

@edif2008
Copy link
Member

Hey @otherguy! 👋

Thank you for your patience!

I’ve brought this up with our dev team and after some discussions, we’ve reached the unfortunate conclusion that we don’t have the necessary time to work on this any time soon. However, if this is a blocker for you, then you’re more than welcome to contribute and open a PR which adds support for other types of workloads. Check out these contributing guidelines for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants