-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow auto restarting of all types of workloads #158
Comments
I agree. We are having the same issue. We are using Argo Rollouts. |
Hey folks! 👋 Thank you for raising this. I will let you know when the team picks this up and there's any progress on this. Thank you for your patience. 😊 |
Hey @edif2008 :) Just wanted to ask if there has been any progress on this? |
Hey @otherguy! 👋 Thank you for your patience! I’ve brought this up with our dev team and after some discussions, we’ve reached the unfortunate conclusion that we don’t have the necessary time to work on this any time soon. However, if this is a blocker for you, then you’re more than welcome to contribute and open a PR which adds support for other types of workloads. Check out these contributing guidelines for details. |
Currently, the operator only restarts
Deployments
but no other type of workload. For exampleDaemonSets
cannot be restarted even though their restart mechanism is the same.We're using
Rollout
s from Argo Rollouts which are a drop-in replacement forDeployment
objects. Their restart mechanism is identical, yet the operator only looks forDeployment
s.Please support restarting all types of workloads, or at least let us add an annotation to workloads to let the operator attempt to restart them, even though it doesn't know about the workloads specific features.
This is tangentially related to #18.
The text was updated successfully, but these errors were encountered: