Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bigint for allocation computations to avoid number conversion error #499

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

Corantin
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Nov 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gardens-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2024 0:15am

Copy link

sentry-io bot commented Nov 30, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: apps/web/components/Proposals.tsx

Function Unhandled Issue
Proposals TypeError: Cannot read properties of undefined (reading 'stakedTokens') /gardens/100/0x71850b7e9ee3f13ab46d67167341e4bdc905eef9/0x6221d5e286cce0d22fc...
Event Count: 1 Affected Users: 3
Proposals TypeError: Cannot read properties of undefined (reading 'stakedTokens') incomplete...
Event Count: 1 Affected Users: 1

Did you find this useful? React with a 👍 or 👎

Copy link
Collaborator

@Mati0x Mati0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Corantin Corantin merged commit cca052c into dev Dec 2, 2024
2 of 3 checks passed
@Corantin Corantin deleted the fix-quadratic-allocation branch December 2, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants