Hide completed proposals #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added a new entry to the .gitignore file to exclude the .graphclientrc.yml configuration from version control. - Updated the GraphQL endpoint version in the configuration. - Add a new template configuration file for GraphQL client settings. - The changes update the GraphQL endpoint configuration for the subgraph client. - Updated the build-client script to generate a graphclient configuration file before building.
…gement - Renamed the property from `proposalId` to `proposalNumber` in the component for clarity. - Renamed the `proposalId` property to `proposalNumber` and updated its references throughout the component. - Added support for managing proposal statuses and modified input handling in the ProposalCard component. - Refactor the Proposals component for improved state management and clarity, enhancing the handling of proposal data and simplifying the input structure.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
!ai |
- Removed conditions for displaying support information in the ProposalCard component.
- Removed the import of ProposalStatus in ProposalCard.tsx. - Refactor the proposals component to filter and display ended proposals more efficiently.
Mati0x
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes focused on improving the handling of proposal identifiers and refactoring the
ProposalCardandProposalscomponents to enhance code readability and maintainability. Key changes include renamingproposalIdtoproposalNumber, updating the state management for proposals, and modifying theinputHandlerfunction.Identifier Renaming:
apps/web/app/(app)/gardens/[chain]/[garden]/[community]/[poolId]/[proposalId]/page.tsx: RenamedproposalIdtoproposalNumberin thePagecomponent. (apps/web/app/(app)/gardens/[chain]/[garden]/[community]/[poolId]/[proposalId]/page.tsxL267-R267)apps/web/components/Charts/ConvictionBarChart.tsx: UpdatedConvictionBarChartPropsand related component logic to useproposalNumberinstead ofproposalId. [1] [2] [3]ProposalCardComponent Updates:apps/web/components/ProposalCard.tsx: ModifiedProposalCardPropsto makeinputDataoptional and changed theinputHandlerfunction to useproposalIdinstead of an index. [1] [2] [3]indexprop and adjusted related logic.ProposalsComponent Refactor:apps/web/components/Proposals.tsx: Refactored state management to use objects keyed byproposalIdinstead of arrays. UpdatedinputHandlerand related functions to reflect this change. [1] [2] [3]Configuration Updates:
pkg/subgraph/.graphclient/index.js: Updated the GraphQL endpoint configuration.pkg/subgraph/.graphclientrc.template.yml: Added template configuration for the GraphQL client.pkg/subgraph/.graphclientrc.yml: Updated the endpoint for thegv2source.pkg/subgraph/package.json: Modified thebuild-clientscript to use a template configuration.