Skip to content
This repository has been archived by the owner on Jun 27, 2018. It is now read-only.

User hasRole does not correctly check LTI 2.x role descriptions #23

Open
screambeard opened this issue Jun 28, 2017 · 2 comments
Open

Comments

@screambeard
Copy link

In the LTI 2.x guide of IMSGlobal the format of the roles can take a new form (as canvas provides). This are shown in the guide you can find here: guide.

For example, canvas provides the following roles:

urn:lti:role:ims/lis/http://purl.imsglobal.org/vocab/lis/v2/institution/person#Instructor
urn:lti:role:ims/lis/http://purl.imsglobal.org/vocab/lis/v2/membership#Instructor
urn:lti:role:ims/lis/http://purl.imsglobal.org/vocab/lis/v2/system/person#User

Which even seem to be a combination of the old and new standard.

Ideally the hasRole function checks for several possibilities. Not it only check for the old standard:

urn:lti:role:ims/lis/Learner
urn:lti:role:ims/lis/Instructor
etc.

I would suggest updating the package to take into account the new standard for roles as well. This should than be added in the User.php file: github link

@screambeard
Copy link
Author

Any update on this? I'm willing to work on this and help resolve it.

@gerysk
Copy link

gerysk commented Feb 7, 2018

The parseRoles function in ToolProvider does not seem to take into consideration the LTI 2.x role format and creates this monstrosity of a role. Is there any update on this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants