Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Python Task Errors #107

Open
4 tasks
robin-173 opened this issue Jan 7, 2021 · 0 comments
Open
4 tasks

Improve Python Task Errors #107

robin-173 opened this issue Jan 7, 2021 · 0 comments

Comments

@robin-173
Copy link
Contributor

robin-173 commented Jan 7, 2021

Review the overall errors from Python tasks. We need to be able to differentiate easily errors which are caused to SAYN setup (e.g. missing module file, wrong name of module file) or Python code error. List of things to fix:

  • wrong reference to class in task definition leads to fairly generic error message (e.g. No module named 'sayn_python_tasks.test') -> capture when the file does not exists (bear in mind the class could be defined at multiple levels: Test, test.Test, test.test.Test).
  • prettify the missing init.py error
  • make the error message clearer when missing Result object returned (i.e. return self.success()/self.fail()). The current error message is: ✖ Result.Err (task_result::missing_result_error): {'result': None}
  • review overall python errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant