Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧Add MKVToolNIx as a post-rip option #95

Open
charmarkk opened this issue Aug 28, 2021 · 5 comments
Open

🔧Add MKVToolNIx as a post-rip option #95

charmarkk opened this issue Aug 28, 2021 · 5 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@charmarkk
Copy link

charmarkk commented Aug 28, 2021

Is your feature request related to a problem? Please describe.
A thought occurred to me. In my current setup, I use a Raspberry Pi 4 as a Plex Server. My clients (Roku, Chromecast) can't display PGS subs (subtitles files from BD discs), so that forces Plex to transcode, which the Pi can't do. I'm currently shuttling them to my main PC (which has a Ryzen 5600x vs. my ARM's current Intel 4590), so it's much faster at transcodes and anything else. But if I could just remux the files to remove the subtitle files (which MKVToolNix can do), that the ARM server can handle. Remuxing is far less intense (I think?) than transcoding, and storage isn't the issue in my setup at the moment.

Describe the solution you'd like
Build in support for MKVToolNix CLI remuxing options, similar to current Handbrake CLI options present in ARM.

Describe alternatives you've considered
Handbrake can do this as it's transcoding, which would be hard for the current ARM server I have. But, I suppose for most, if their machine is powerful enough, Handbrake can kill two birds with one stone.

Are you able to help code/implement this feature ?
Possibly. I'm no Python coder but I've dabbled with MKVToolNix on my Pi before and it's not awfully difficult.

Additional context
This would be moot if someone has a powerful machine for transcoding and remuxing - again, two birds - but if someone just wanted to remux to remove languages/subtitles from rips (and not deal with MakeMKV's rather....involved arguments), this could be a good option.

Perhaps I just need to really look into MakeMKV's documentation and try it. Or, perhaps this is an opportunity for a more fleshed out MakeMKV docs section here? With examples - that's the part I'm struggling with when reading MakeMKV's docs.

@charmarkk charmarkk added the enhancement New feature or request label Aug 28, 2021
@1337-server
Copy link
Owner

I'll look into this if I get some free time this week, as for the MakeMKV dev docs they aren't the greatest and rather lacking. Their forums are a great place to look for more information though.

@1337-server 1337-server added the help wanted Extra attention is needed label Aug 31, 2021
@charmarkk
Copy link
Author

Awesome, let me know if I could help with pseudocode or HTML work. Like I said, I might not be much help with the Python. :)

I've tried looking through their forums, I think it's moreso the args that are confusing, more than the docs themselves sometimes! lol

@1337-server 1337-server moved this to Todo in ARM 2.7.0 Mar 16, 2022
@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the Stale label Mar 20, 2022
@1337-server
Copy link
Owner

Sorry, this was way on the back of things to do. But I have looked into this, wouldn't it be easier to use a MakeMKV profile and deselect the subs ?

/home/arm/.MakeMKV/settings.conf

app_DefaultSelectionString = "-sel:all,+sel:audio&(eng),-sel:(havemulti),-sel:mvcvideo,+sel:subtitle&(eng),-sel:special,=100:all,-10:eng"

This is what it does split by the , in the string

  • deselect everything (-sel:all)
  • select English audio (+sel:audio&(eng))
  • deselect different angles (-sel:(havemulti))
  • deselect 3d (-sel:mvcvideo)
  • select English subtitles (+sel:subtitle&(eng))
  • deselect special features (-sel:special)
  • prioritize English (=100:all,-10:eng)

You could do something like

app_DefaultSelectionString = "-sel:all,+sel:audio&(eng),-sel:(havemulti),-sel:mvcvideo,-sel:special,=100:all,-10:eng"

Inside /home/arm/.MakeMKV/settings.conf and that should remove all subtitles.

I'm still happy to look into adding MKVToolNix it's just that it might take a while. I have a bunch of bugs still to fix, so it's unlikely to be anytime soon.

@charmarkk
Copy link
Author

charmarkk commented Apr 19, 2022 via email

@1337-server 1337-server removed this from ARM 2.7.0 Apr 24, 2022
@github-actions github-actions bot removed the Stale label Jul 5, 2022
@1337-server 1337-server changed the title Add MKVToolNIx as a post-rip option 🔧Add MKVToolNIx as a post-rip option Jul 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants