Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Support Azure Storage #67

Open
roopemerikukka opened this issue Aug 24, 2020 · 2 comments
Open

Feature Request: Support Azure Storage #67

roopemerikukka opened this issue Aug 24, 2020 · 2 comments

Comments

@roopemerikukka
Copy link

This project is awesome but unfortunately our current client is tied to Microsoft's cloud infrastructure so I'm asking if you have considered adding support for Azure Storage? It seems to have an official SDK available for use.

This could also mean wider design decisions to support multiple cloud providers like Google etc. as well or having some kind of system for developers to hook up their own storage system.

Another solution could be to have an option to save the snapshot locally and use that local version instead of the centralized repository. While this lacks the testability between developers it could still be useful for CI/CD pipelines.

@tlovett1
Copy link
Member

tlovett1 commented Sep 1, 2020

Hey, thanks for opening the issue. We haven't considered that. I don't think we'd make that a priority to work on internally but would be open to reviewing PRs from others.

@aaemnnosttv
Copy link
Member

It's worth noting that there are many cloud storage providers which offer S3-compliant APIs. You can see one example of how to configure this for DigitalOcean Spaces here https://www.digitalocean.com/docs/spaces/resources/s3-sdk-examples/.

It seems the main thing missing to make this possible with wpsnapshots is for the S3Client's endpoint to be configurable.

There may be other things needed to change, but at a high-level it shouldn't be very difficult to allow wpsnapshots to work with other compliant storage providers. I think this would be a logical first step in decoupling wpsnapshots from S3. Adding support for other providers that aren't already S3 compliant would likely require more substantial changes to use an abstraction layer like Flysystem which has adapters for S3, Azure, and many others.

@jeffpaul jeffpaul added this to the Future Release milestone Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants