Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a progress bar #41

Closed
wants to merge 8 commits into from
Closed

Adds a progress bar #41

wants to merge 8 commits into from

Conversation

ChaosExAnima
Copy link
Contributor

Fixes #27. Adds a progress bar to track S3 uploads and downloads.

@tlovett1 - What's the best way to test this? The dev environment here isn't clear to me.

@ChaosExAnima ChaosExAnima self-assigned this Oct 5, 2018
@tlovett1
Copy link
Member

tlovett1 commented Oct 6, 2018

Hey @ChaosExAnima, this is awesome! There isn't any dev environment. I'll test.

@ChaosExAnima
Copy link
Contributor Author

@tlovett1 - Okay! I may spend some time next week adding a dev environment via Docker. If there's a test AWS bucket/db I can use that'd be appreciated :)

@ChaosExAnima
Copy link
Contributor Author

@tlovett1 - Any word here? I'd love to get this up on Docker Hub as a beta for testing in projects.

@tlovett1
Copy link
Member

@ChaosExAnima I feel like if we are adding one progress bar, we should add them everywhere anything is time consuming:

  • Downloading a snapshot
  • Exporting a database
  • Importing a database
  • Running search/replace on a database
  • Compressing files

What are your thoughts? I'll ping you separately about the Docker thing.

@ChaosExAnima
Copy link
Contributor Author

I think that's totally doable. May be good to make a Progress class to handle this and inject that into the appropriate locations.

Note though this PR adds a progress bar for both downloads and uploads, pretty much any operation on AWS. I can hook up local FS operations too, though.

@tlovett1
Copy link
Member

Yea agreed we probably want to abstract out the progress bar code a bit. Want to update the PR with adding the progress bar to the entire list?

@ChaosExAnima
Copy link
Contributor Author

Hey @tlovett1! I've implemented the progress bar across most operations as a generic class. If you can review when you get a sec, I would appreciate it!

@jeffpaul
Copy link
Member

jeffpaul commented Oct 8, 2019

@tlovett1 any updates from your review on this one?

@ChaosExAnima ChaosExAnima removed their assignment Oct 8, 2019
@jeffpaul jeffpaul added this to the 1.6.4 milestone May 7, 2020
@jeffpaul
Copy link
Member

@tlovett1 any updates on your review of this PR?

@jeffpaul jeffpaul linked an issue Jul 14, 2020 that may be closed by this pull request
@ChaosExAnima ChaosExAnima removed their assignment Jul 14, 2020
@ChaosExAnima
Copy link
Contributor Author

Hey @jeffpaul! I'm no longer using this tool nor have any access to this repo, so I am not in a position to respond to issues.

@jeffpaul jeffpaul modified the milestones: 1.6.4, 2.0.2 Sep 1, 2020
@jeffpaul jeffpaul modified the milestones: 2.2.0, 2.1.0 Nov 6, 2020
@jeffpaul jeffpaul mentioned this pull request Nov 6, 2020
15 tasks
@tlovett1 tlovett1 closed this Dec 1, 2020
@jeffpaul jeffpaul deleted the fix/27-progress-bar branch March 5, 2021 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide progress for S3 operations
3 participants