Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show more hints/warnings in the admin #12

Open
4 tasks
helen opened this issue Dec 18, 2017 · 0 comments
Open
4 tasks

Show more hints/warnings in the admin #12

helen opened this issue Dec 18, 2017 · 0 comments
Labels
type:enhancement New feature or request.

Comments

@helen
Copy link
Contributor

helen commented Dec 18, 2017

There are a few technical requirements for the plugin which should be handled in case a user still decides to try activating the plugin:

  • PHP 5.3+, mostly for __DIR__ and namespace reasons (for now). This is handled by WordPress core's sandboxing right now, as it fatals and is subsequently deactivated. It's possible nothing else needs to be done here other than trying to advance the relevant core ticket.
  • WordPress 4.9+, for the usage of CodeMirror as bundled. The editor likely still (mostly) works anyway, though there may be some JS errors, but hasn't been tested. It almost certainly requires 4.6+ for language pack reasons. Not sure what the plugin should do - I believe it would have to be installed manually rather than from the plugin repo as it is, so do we need to worry much about a warning?
  • Rewrites enabled, so that WordPress can actually catch the request to /ads.txt. Perhaps a warning on the plugins page/row and on the edit screen?
  • Site URL must not contain a path, as per spec this is a root-level file and the plugin only attempts to serve it there. Perhaps also a warning with explanation on the plugins page/row and on the edit screen?

Since this plugin has a bit of a smaller audience this wasn't 1.0 priority, but we should still aim for the best possible experience.

@helen helen added the type:enhancement New feature or request. label Feb 15, 2018
@jeffpaul jeffpaul added this to the Future Release milestone Apr 25, 2019
@jeffpaul jeffpaul modified the milestones: Future Release, 1.3.0 Jan 13, 2020
@peterwilsoncc peterwilsoncc modified the milestones: 1.4.0, Future Release Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New feature or request.
Projects
None yet
Development

No branches or pull requests

3 participants