Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#10] Add leaderboard page and components #29

Merged
merged 12 commits into from
Aug 6, 2020
Merged

[#10] Add leaderboard page and components #29

merged 12 commits into from
Aug 6, 2020

Conversation

antoniolofiego
Copy link
Collaborator

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes/features)
  • Build (npm run build) was run locally and any changes were pushed

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

No leaderboard.

Issue Number: #10

What is the new behavior?

Yes leaderboard.
Also refactored the header to include the leaderboard link, as well as turning the logo in a home button. A few images had no alt captions, so I added them.

Does this introduce a breaking change?

  • Yes
  • No

Other information

None on the frontend.

@antoniolofiego antoniolofiego linked an issue Aug 5, 2020 that may be closed by this pull request
@antoniolofiego antoniolofiego self-assigned this Aug 5, 2020
@antoniolofiego antoniolofiego added enhancement New feature or request Refactor Restructure the code for better performance labels Aug 5, 2020
@antoniolofiego antoniolofiego added this to the Full component suite milestone Aug 5, 2020
@antoniolofiego antoniolofiego merged commit 21a7799 into 100DaysOfCloud:dev Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Refactor Restructure the code for better performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Leaderboard Page
1 participant