Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Unit tests #6

Open
kristovatlas opened this issue Jan 7, 2017 · 1 comment
Open

feat: Unit tests #6

kristovatlas opened this issue Jan 7, 2017 · 1 comment
Labels
enhancement

Comments

@kristovatlas
Copy link
Contributor

Some unit tests would be helpful. This is easiest with database-related stuff; network behavior is slower and thus less convenient to unit test.
@0xd34db33f
Copy link
Owner

Yeah definitely makes sense to add some good testing functionality to it. Thinking out loud really as I'm not sure where the testing segmentation lies between the wrapping code vs dnstwist code. If we end up testing the dnstwist functionality, wonder if it makes sense pushing something upstream and then modeling the additional tests we are building for GFYP based on that. I'll muse on it here.

@kristovatlas kristovatlas changed the title Unit tests feat: Unit tests Jan 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kristovatlas @0xd34db33f