Skip to content
This repository has been archived by the owner on Aug 12, 2023. It is now read-only.

Add filters to the fills page #72

Closed
cbovis opened this issue Oct 25, 2018 · 6 comments
Closed

Add filters to the fills page #72

cbovis opened this issue Oct 25, 2018 · 6 comments
Labels
enhancement New feature or request

Comments

@cbovis
Copy link
Contributor

cbovis commented Oct 25, 2018

The fills page at https://0xtracker.com/fills would be much more useful to people interested in exploring the data set if there were filters available.

A good set of initial filters would be:

  • Relayer(s)
  • Protocol Version
  • Token(s)
  • Date Range

The API will need updating to support these options when fetching fills before this can be implemented.

Design Inspiration

filters

@vnallamhawk
Copy link

@cbovis : can i take this up ?

@cbovis
Copy link
Contributor Author

cbovis commented Jan 8, 2019

Best to hold off on this one for now. A couple of things:

  • 0x-tracker-api will need updating to support filtering of fills
  • the client codebase is currently in flux (see UI Refresh #197), so its best to avoid any major feature development until UI Refresh #197 has been merged

@vnallamhawk
Copy link

vnallamhawk commented Jan 14, 2019

When would #197 be merged ?

@cbovis
Copy link
Contributor Author

cbovis commented Jan 17, 2019

#197 has been merged now so this is good to be worked on. First steps for this repository will be designing the filter component in Storybook. Once that has been completed and the API has been updated to support filters we’ll be able to wire them together.

On mobile right now but I’ll put together some more extensive requirements once I’m back on my laptop.

@vnallamhawk
Copy link

@cbovis : thanks for the update. Could you please help with the requirement. I am eagerly waiting for kickstarting on this. Thanks.

@cbovis
Copy link
Contributor Author

cbovis commented Dec 15, 2019

Tracking of this issue has been moved to #769 which has a number of sub-tasks associated with it.

@cbovis cbovis closed this as completed Dec 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants