Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: verify contracts with starkscan #228

Open
ivpavici opened this issue Oct 5, 2022 · 3 comments
Open

Feat: verify contracts with starkscan #228

ivpavici opened this issue Oct 5, 2022 · 3 comments
Labels
enhancement New feature or request OnlyDust Open for OnlyDust contributors

Comments

@ivpavici
Copy link
Contributor

ivpavici commented Oct 5, 2022

Inspired by: https://github.com/martriay/nile-verifer-plugin/blob/main/nile_verifier/main.py

https://starkscan.co/

https://github.com/starkscan/starkscan-verifier

@ivpavici ivpavici moved this to 🆕 New in starknet-hardhat-plugin Oct 5, 2022
@ivpavici ivpavici added enhancement New feature or request OnlyDust Open for OnlyDust contributors labels Dec 6, 2022
@FabijanC
Copy link
Collaborator

What would be the advantages of having starkscan verification integrated into the plugin, compared to using the official CLI tool (https://github.com/starkscan/starkscan-verifier)

@ivpavici
Copy link
Contributor Author

Hardhat itself supports this feature for Ethereum:
https://hardhat.org/hardhat-runner/docs/guides/verifying

@FabijanC
Copy link
Collaborator

It should be noted that we already have this feature for Voyager. I don't know if the API is up to date (because it's included in alpha-goerli tests which we have been skipping for months now). I also don't know how many people are using either Voyager or our CLI command to verify there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request OnlyDust Open for OnlyDust contributors
Projects
Status: 🆕 New
Development

No branches or pull requests

2 participants