Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings #118

Merged
merged 6 commits into from
Jun 28, 2023
Merged

Fix warnings #118

merged 6 commits into from
Jun 28, 2023

Conversation

notV4l
Copy link
Contributor

@notV4l notV4l commented Jun 23, 2023 •
edited by FabijanC
Loading

  • Close Fix warnings caused by err: any  #86
  • add dist to .gitignore
  • update eslint, @typescript-eslint/eslint-plugin, @typescript-eslint/parser versions
  • add utility functions for error assertion

@notV4l notV4l changed the title Plugin Fix warnings Jun 23, 2023
@FabijanC FabijanC self-requested a review June 26, 2023 07:17
@FabijanC FabijanC linked an issue Jun 26, 2023 that may be closed by this pull request
Fix warnings caused by err: any #86
Open
FabijanC
FabijanC requested changes Jun 27, 2023
View reviewed changes
Copy link
Collaborator

@FabijanC FabijanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've fixed StarknetPluginError, try using it now instead of HardhatPluginError (first importing it from @shardlabs/starknet-hardhat-plugin).

I see there is still one any left in expectFeeEstimationStructure. We could import the missing interface from @shardlabs/starknet-hardhat-plugin.

cairo1-contracts/events1.cairo Outdated Show resolved Hide resolved
hardhat.config.ts Show resolved Hide resolved
test/argent-account-test.ts Outdated Show resolved Hide resolved
test/argent-account-test.ts Outdated Show resolved Hide resolved
FabijanC
FabijanC reviewed Jun 28, 2023
View reviewed changes
test/util.ts Outdated Show resolved Hide resolved
@FabijanC FabijanC merged commit 722fab9 into 0xSpaceShard:plugin Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabijanC FabijanC FabijanC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix warnings caused by err: any
2 participants
@notV4l @FabijanC