Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve checks in CI/CD #116

Open
FabijanC opened this issue Jun 21, 2023 · 0 comments
Open

Improve checks in CI/CD #116

FabijanC opened this issue Jun 21, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@FabijanC
Copy link
Collaborator

FabijanC commented Jun 21, 2023

Currently we just lint, but we would benefit from doing what I have in my pre-commit script:

set -e

# check typescript correctness
npx tsc --noEmit

# check all .sh files are executable
invalid_scripts=0
for script in $( find . -type f -iname *.sh ); do
    if [ ! -x $script ]; then
        echo "Script $script is not executable"
        invalid_scripts=$((invalid_scripts + 1))
    fi
done
if [ $invalid_scripts != 0 ]; then
    exit 1
fi

#  check there are no it.only occurrences in the tests
grep -re "it\.only(" $(git ls-files '*.ts') && echo "Error: There are files with it.only(...)" && exit 2

# lint
npm run lint
@FabijanC FabijanC added the enhancement New feature or request label Jun 21, 2023
@FabijanC FabijanC self-assigned this Jun 21, 2023
@FabijanC FabijanC assigned Nathan-SL and unassigned FabijanC Jul 24, 2023
This was referenced Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 🆕 New
Development

No branches or pull requests

2 participants