-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve testing of starknet_simulateTransactions #192
Comments
Hey there! This sounds like a good first issue to work on and try my rust skills! Could I get assigned to it? I also understand Python so checking out the devnet-py test will be easy. |
@joseSalazar4 you've been assigned |
Try adding two more tests:
If you feel the tests are too similar, then just add one. In any case, feel free to create at least a draft PR even if you're not yet done (but indicating so). That way we can see exactly what you've done so far and make concrete suggestions. |
Tests in
crates/starknet-devnet/tests/test_simulate_transactions.rs
were written to have the same coverage as devnet-py the corresponding devnet-py tests. Currently there are TODOs:- Another test needs replacement of .ge with .gt (basically we would want to assert that using SKIP_VALIDATE actually lowers the estimated fee, but currently it does not have effect, as described in this issue: SKIP_VALIDATE not affecting fee in simulation lambdaclass/starknet_in_rust#1051)This issue can be addressed separately as it would not merely be enhancement but fix.simulate(...)
instead of manually constructing simulation requests.The text was updated successfully, but these errors were encountered: