New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support batching of more than two columns for Starky LogUp helper columns #1622

Open

hratoanina opened this issue Sep 4, 2024 · 0 comments

Labels

Contributor

hratoanina commented Sep 4, 2024

From a message on Discord:
We are currently only allowing constraints of degree 3 or less for computing LogUp helper columns in Starky:

plonky2/starky/src/lookup.rs

Line 655 in bf95c10

pub(crate) fn eval_helper_columns<F, FE, P, const D: usize, const D2: usize>(

We could make the code support any degree by allowing batching of more than two columns together.
(This is currently low priority for our use case.)

hratoanina added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment