Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase testing in starky crate #1514

Open
Nashtare opened this issue Feb 10, 2024 · 3 comments
Open

Increase testing in starky crate #1514

Nashtare opened this issue Feb 10, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@Nashtare
Copy link
Collaborator

The starky crate doesn't have much unit tests, and would benefit from a stronger test suite covering the different setups that can be used.

@Nashtare Nashtare added the enhancement New feature or request label Feb 11, 2024
@Nashtare Nashtare added this to the Cleanups and Misc. milestone Mar 12, 2024
@shreyas-londhe
Copy link

Hi @Nashtare, I'm interested in working on this, can you please guide me on what needs to be done?

@Nashtare
Copy link
Collaborator Author

Nashtare commented Apr 1, 2024

Hey @shreyas-londhe! Thanks for your interest in this!
It's mostly about testing the cross-functionalities between different scenarios at the moment. We currently support testing simpler STARKs with:

  • only regular constraints
  • no regular constraints but a permutation argument

We do lack of CTLs test strentghening, which involve defining some simple system across 2 or 3 tables operating on common values. We'd probably need some consistency checks around challenge computations and quotient polynomial evaluation for badly used parameters cases (like not specifying a requires_ctls for a table in a multi-STARK for instance).

We'd probably also need some higher-degree test cases for STARKs, valid & invalid cases ideally. But not everything has to be done at once, this can be a long-running task :) Let me know if you have any additional question!

@Nashtare
Copy link
Collaborator Author

@shreyas-londhe Do you need help on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Backlog
Development

No branches or pull requests

2 participants