Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve conditionally_verify_proof #1103

Open
hrmk1o3 opened this issue Jun 22, 2023 · 0 comments
Open

Improve conditionally_verify_proof #1103

hrmk1o3 opened this issue Jun 22, 2023 · 0 comments

Comments

@hrmk1o3
Copy link

hrmk1o3 commented Jun 22, 2023

I think the implementation of conditionally_verify_proof could be improved. Instead of inputting and selecting two proofs, only the relevant proofs need to be inputted. This has significantly reduced the number of gates in the circuit.

Here is the implementation that two kinds of recursion proofs can be verified by using the same circuit. aggregated_circuit1 is the conventional way and aggregated_circuit2 is the improved one.

Please let me know if there are any mistakes.

@Nashtare Nashtare added this to the Cleanups and Misc. milestone Jun 5, 2024
@Nashtare Nashtare modified the milestones: Misc., Performance Tuning Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

2 participants