Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli-utils): Fix regressed CLI exit codes on errors #329

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Conversation

kitten
Copy link
Member

@kitten kitten commented Jun 26, 2024

Resolves #326

Summary

A prior regression meant that process.exitCode wasn't being set any longer.
This has now been fixed and errors now cause process.exitCode to be set correctly and as intended again.

Set of changes

  • Add missing CLIError#exit to process.exitCode copying

Copy link

changeset-bot bot commented Jun 26, 2024

🦋 Changeset detected

Latest commit: fd3c90a

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kitten kitten requested a review from JoviDeCroock June 26, 2024 10:16
@kitten kitten merged commit e14335a into main Jun 26, 2024
2 checks passed
@kitten kitten deleted the fix/exit-code branch June 26, 2024 10:48
@github-actions github-actions bot mentioned this pull request Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gql.tada check returns exit code 0 with errors
2 participants