Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to Go1.20 #550

Merged
merged 3 commits into from
Nov 20, 2023
Merged

update to Go1.20 #550

merged 3 commits into from
Nov 20, 2023

Conversation

boddumanohar
Copy link
Contributor

A brief description of the changes in this PR:

gosdk is updated to go1.20. due to this, build zboxcli using the go1.18 fails with this error:

b6/zboxcore/sdk/writemarker_mutex.go
# github.com/0chain/gosdk/zboxcore/sdk
../go/pkg/mod/github.com/0chain/[email protected]/zboxcore/sdk/chunked_upload_model.go:84:28: undefined: context.CancelCauseFunc
../go/pkg/mod/github.com/0chain/[email protected]/zboxcore/sdk/chunked_upload.go:174:31: undefined: context.WithCancelCause
../go/pkg/mod/github.com/0chain/[email protected]/zboxcore/sdk/chunked_upload.go:488:31: undefined: context.WithCancelCause
../go/pkg/mod/github.com/0chain/[email protected]/zboxcore/sdk/chunked_upload.go:644:18: undefined: context.Cause
../go/pkg/mod/github.com/0chain/[email protected]/zboxcore/sdk/chunked_upload.go:652:19: undefined: context.Cause
../go/pkg/mod/github.com/0chain/[email protected]/zboxcore/sdk/chunked_upload.go:778:8: err declared but not used
note: module requires Go 1.20
make: *** [Makefile:28: zbox] Error 2

So let update zboxcli's go version

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • 0chain:
  • blobber:
  • gosdk:
  • system_test:
  • zwalletcli:
  • Other: ...

@boddumanohar boddumanohar changed the base branch from staging to sprint-1.11 November 15, 2023 12:10
Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dabasov dabasov merged commit 27eabcb into sprint-1.11 Nov 20, 2023
5 of 7 checks passed
@dabasov dabasov deleted the go1.20 branch November 20, 2023 14:41
dabasov added a commit that referenced this pull request Dec 19, 2023
* Updated self hosted macos-runner & windows-runner (#517)

* Updated self hosted macos-runner & windows-runner

* updated self hosted runners

* Fix upload --web-streaming (#527)

* Fix upload --web-streaming

Update gosdk to use correct ffmpeg commands

* Fix tests

* fix(gomod): upgraded gosdk with latest sprint-1.11

* chore(gomod): go mod tidy

---------

Co-authored-by: Lz <[email protected]>

* feature: added all provider for stake pool related commands (#526)

* update gosdk for list optimization

* updated gosdk

* update gosdk

* fix wait when using multiupload (#533)

* use msys2 to build windows binaries (#524)

* debug windows builds

* start builds on PRs

* remove un-used targets

* fix syntax error

* run only windows

* printend

* remove set GITHUB_ENV

* install make

* install choco

* set choco install path

* build-windows

* install zip

* also include dll files in the zip file

* comment out upload-release-action git action

* also install unzip

* cleanup release

* cleanup workspace

* overwrite current files while unzipping

* add back gosdk.yaml

* use .yml extension

* actions checkout

* use docker to build linux binary

* lsb_release print

* Revert "Merge pull request #498 from 0chain/hm90121-patch-1"

This reverts commit 33f24ae, reversing
changes made to 46d3112.

* Remove download from single blobber (#543)

* Fix download (#544)

* updated gosdk

* Cleaned up update_terms flag

* update gosdk (#548)

* add ubuntu 20 runner (#546)

* add ubuntu 20 runner

* fix runner

* add ubuntu20 runner

* add ubuntu20 runner

* add ubuntu20 runner

* fix runner

* add ubuntu 20 runner

* add ubuntu 20 runner

* add ubuntu 20 runner

* add ubuntu 20 runner

---------

Co-authored-by: Yury <[email protected]>

* update gosdk

* go mod tidy

* Updated gosdk (#551)

* Un Comment windows and macos build runs (#549)

* uncomment windows build runs

* update gosdk to the latest

* update to Go1.20 (#550)

* update to go version 1.20

* update gosdk

---------

Co-authored-by: Yury <[email protected]>

* Fix update alloc min lock

* Feature: implement fork per run strategy (#553)

* feature: added fork creation

* fix: fixed bug

* feature: improved Tenderly fork creation flow

* update gosdk (#557)

* feature: added custom block number during Tenderly fork creation (#560)

* upgrade GoSDK to sprint-1.11 (#559)

Co-authored-by: service-0chain <[email protected]>

* Fix update alloc min lock

* upgrade GoSDK to sprint-1.11

* upgrade GoSDK to sprint-1.11 (#564)

Co-authored-by: service-0chain <[email protected]>

* upgrade GoSDK to sprint-1.11 (#566)

Co-authored-by: service-0chain <[email protected]>

* upgrade GoSDK to sprint-1.11 (#567)

Co-authored-by: service-0chain <[email protected]>

* use multi download in sync (#569)

* update gosdk to v1.11.0 (#571)

---------

Co-authored-by: Kishan Dhakan <[email protected]>
Co-authored-by: shahnawaz-creator <[email protected]>
Co-authored-by: peterlimg <[email protected]>
Co-authored-by: Lz <[email protected]>
Co-authored-by: Yaroslav Svitlytskyi <[email protected]>
Co-authored-by: Hitenjain14 <[email protected]>
Co-authored-by: dabasov <[email protected]>
Co-authored-by: Kishan Dhakan <[email protected]>
Co-authored-by: Hitenjain14 <[email protected]>
Co-authored-by: devyetii <[email protected]>
Co-authored-by: Jayash Satolia <[email protected]>
Co-authored-by: Jayash Satolia <[email protected]>
Co-authored-by: Tapish Sinha <[email protected]>
Co-authored-by: GuruHubb <[email protected]>
Co-authored-by: service-0chain <[email protected]>
Co-authored-by: service-0chain <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants