Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variable overwrite #336

Open
lpoli opened this issue Dec 26, 2021 · 2 comments
Open

Variable overwrite #336

lpoli opened this issue Dec 26, 2021 · 2 comments
Assignees
@lpoli
Labels
post-mainnet

Comments

@lpoli
Copy link
Contributor

lpoli commented Dec 26, 2021

https://github.com/0chain/gosdk/blame/staging/zcncore/transaction.go#L796
https://github.com/0chain/gosdk/blame/staging/zcncore/transaction.go#L516
https://github.com/0chain/gosdk/blame/staging/zcncore/transaction.go#L680

Above overwriting seems erroneous. numSharders argument is passed but it is overwritten in suspicious manner.
@lpoli
Copy link
Contributor Author

lpoli commented Dec 26, 2021

@cnlangzi Can you please check if this is issue that needs to be resolved?

@cnlangzi
Copy link
Contributor

cnlangzi commented Dec 27, 2021 •
edited
Loading

@lpoli We had a lot of discussion about it. I would suggest to leave it first. Because it is used by too much code. it is great if you have enough time to improve and test them

@cnlangzi cnlangzi assigned lpoli and unassigned cnlangzi Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lpoli lpoli

Labels
post-mainnet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cnlangzi @lpoli